Add support for compiling both ARM and x86_64 on Github CI - #13
Open
IdyllicHappiness wants to merge 2 commits into
Open
Add support for compiling both ARM and x86_64 on Github CI#13IdyllicHappiness wants to merge 2 commits into
IdyllicHappiness wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, really nice and handy project! 🙂
I noticed there wasn't an Apple Silicon native build, so I made a couple of changes to allow for Github to compile both x86_64 and ARM versions on MacOS.
The runner
macos-latestis actually an ARM one now, so by default it would build an ARM executable.The change I made was just to pass
makethrough thearchcommand for each architecture (works due to Apple'smakebeing a universal binary, and Rosetta allowing x64_86 to be run on the ARM runner).I also changed the directory specified in the publish section so it matches those used in the build sections.
All seems to work nicely on my test build - https://github.com/IdyllicHappiness/tty-copy/releases/tag/v0.2.3
Cheers!
IdyllicHappiness